fix: remove html errors

alberto-rj · Sep 7, 2024 · 14491d5 · 14491d5
1 parent 727f062
commit 14491d5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/index.html b/index.html
@@ -59,7 +59,7 @@
   <link rel="stylesheet" href="styles/index.min.css" />
 
   <!-- JS -->
-  <script type="module" src="src/index.min.js" defer></script>
+  <script type="module" src="src/index.min.js"></script>
 </head>
 <body class="page">
   <main class="content">
@@ -84,7 +84,6 @@ <h1 id="intro-heading">Calculate Your Tips Accurately</h1>
           width="87" 
           height="54" 
           aria-hidden="true" 
-          focusable="false"
           class="logo__icon"
         />
       </a>
@@ -171,7 +170,6 @@ <h1 id="intro-heading">Calculate Your Tips Accurately</h1>
               min="0" 
               max="100" 
               step="0.01" 
-              maxlength="6"
               placeholder="0.00" 
               aria-label="Enter a custom tip percentage, between 0 and 100 percent" 
               class="form__input"
@@ -188,8 +186,7 @@ <h1 id="intro-heading">Calculate Your Tips Accurately</h1>
             type="number" 
             inputmode="numeric" 
             min="1" 
-            max="100" 
-            maxlength="3"
+            max="100"
             aria-label="Enter number of people splitting the bill, between 1 and 100" 
             aria-required="true" 
             required 
@@ -222,7 +219,6 @@ <h2 aria-live="polite" class="output__heading">
           id="reset-btn" 
           type="button" 
           aria-label="Reset all inputs and calculated results" 
-          aria-disabled="true"
           disabled 
           class="output__btn"
         >

diff --git a/src/index.js b/src/index.js
@@ -63,11 +63,6 @@ const removeClass = (element, className) => {
 
 const setDisabled =  (element, status) => {
   status = status === true;
-  if (status) {
-    element.setAttribute('aria-disabled', status);
-  } else {
-    element.removeAttribute('aria-disabled');
-  }
   element.disabled = status;
 };
 

diff --git a/src/index.min.js b/src/index.min.js