-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand target selection to other Ag commands #25
Comments
I propose instead of calling :<C-u>call ag#autoargs('ag#AgBuffer') then you can keep |
To make architecture more flexible and finally allow to implement #23, #26 clearly, I grouped functions into categories by type of argument for It's somewhat big commit, because I couldn't think of incremental way to introduce splitting and changes in architecture. This work took much of my free time to refine and discard dozens of possible implementations, until I decided on this way. Therefore if you have objections I simply fork out:) Because I really need that changes, even if you agrees with maintainer at rking#124 about non-intrusive contributing. |
Just a few notes: I like to be on the edge and clearly ag.vim codebase isn't robust. So all your changes are right for me. Just see the far you get the hard you will be on contribute ag.vim upstream. You are creating a real fork rather than a contribute fork. The question is: Apart for upgrade your own workbench, do you want to share these with the community? In that case you need to honor the recognition rking repo achieve and accept worst codebase and other programmers vision to contribute the community and see your work on other machines. For me the option is to take both approachs. Do whatever nasty things you want here on master, but keep an eye on upstream to share as much as you can to bring back something to community. |
Speaking about priority -- its edge first sharing second. Not too distant though. |
I think, I will not merge long-lived |
Good move. Lot to say? Speak it slowly. |
Might we close this issue by now? We can reopen later if needed |
Alright, it has sense. Work was done, though not merged yet. |
You introduced auto-select function
ag#GetArgs
.It has sense to expand its usage to other
ag#...
functions, to introduce more useful<Plug>(ag-...
mappings.The text was updated successfully, but these errors were encountered: