-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2178
Conversation
Reviewer's Guide by SourceryThis PR includes three main changes: an improvement to the sharpen_gaussian function implementation using the unsharp mask formula, addition of the @clipped decorator, and updates to dependencies and version numbers. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more descriptive PR title that explains the changes (e.g., 'Improve sharpen_gaussian implementation and update dependencies')
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2178 +/- ##
=========================================
+ Coverage 0 89.74% +89.74%
=========================================
Files 0 47 +47
Lines 0 8434 +8434
=========================================
+ Hits 0 7569 +7569
- Misses 0 865 +865 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Fix the sharpen_gaussian function to correctly apply the unsharp mask formula, update the pre-commit configuration to use Ruff version 0.8.2, and bump the project version to 1.4.22.
Bug Fixes:
Build:
Chores: