Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2178

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Fixes #2178

merged 3 commits into from
Dec 6, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Dec 6, 2024

Summary by Sourcery

Fix the sharpen_gaussian function to correctly apply the unsharp mask formula, update the pre-commit configuration to use Ruff version 0.8.2, and bump the project version to 1.4.22.

Bug Fixes:

  • Fix the sharpen_gaussian function to correctly apply the unsharp mask formula.

Build:

  • Update the pre-commit configuration to use Ruff version 0.8.2.

Chores:

  • Bump the project version from 1.4.21 to 1.4.22.

Copy link
Contributor

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR includes three main changes: an improvement to the sharpen_gaussian function implementation using the unsharp mask formula, addition of the @clipped decorator, and updates to dependencies and version numbers.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved sharpen_gaussian function implementation using unsharp mask formula
  • Replaced add_weighted call with direct unsharp mask formula implementation
  • Added explanatory comment describing the unsharp mask formula
  • Added @clipped decorator to ensure output values stay within valid range
albumentations/augmentations/functional.py
Updated dependency versions and package version
  • Bumped ruff-pre-commit from v0.8.1 to v0.8.2
  • Incremented package version from 1.4.21 to 1.4.22
.pre-commit-config.yaml
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more descriptive PR title that explains the changes (e.g., 'Improve sharpen_gaussian implementation and update dependencies')
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (b1a79c2) to head (587d8df).
Report is 302 commits behind head on main.

Files with missing lines Patch % Lines
albumentations/augmentations/functional.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2178       +/-   ##
=========================================
+ Coverage      0   89.74%   +89.74%     
=========================================
  Files         0       47       +47     
  Lines         0     8434     +8434     
=========================================
+ Hits          0     7569     +7569     
- Misses        0      865      +865     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit ff5cf99 into main Dec 6, 2024
16 checks passed
@ternaus ternaus deleted the fixes branch December 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant