-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecations from CenterCrop #2233
Conversation
Reviewer's Guide by SourceryThis PR removes deprecated arguments from the Class diagram showing changes to InitSchema classclassDiagram
class InitSchema {
+height: int
+width: int
+pad_if_needed: bool
+pad_position: PositionType
+border_mode: BorderModeType
+fill: ColorType
+fill_mask: ColorType
-pad_mode: BorderModeType [REMOVED]
-pad_cval: ColorType [REMOVED]
-pad_cval_mask: ColorType [REMOVED]
-validate_dimensions() [REMOVED]
}
note for InitSchema "Removed deprecated parameters
and validation method"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document this breaking change in the changelog/release notes, as removing these deprecated parameters will affect users who haven't yet updated to the new parameter names.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
=========================================
+ Coverage 0 89.60% +89.60%
=========================================
Files 0 50 +50
Lines 0 9205 +9205
=========================================
+ Hits 0 8248 +8248
- Misses 0 957 +957 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Enhancements:
CenterCrop