-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CoarseDropout #2241
Updated CoarseDropout #2241
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Class diagram showing changes to CoarseDropout classclassDiagram
class CoarseDropout {
-num_holes_range: tuple[int, int]
-hole_height_range: tuple[ScalarType, ScalarType]
-hole_width_range: tuple[ScalarType, ScalarType]
-fill: DropoutFillValue
-fill_mask: ColorType
-p: float
+__init__(num_holes_range=(1,2), hole_height_range=(0.1,0.2), hole_width_range=(0.1,0.2), fill=0, fill_mask=None, p=0.5)
}
note for CoarseDropout "Removed deprecated parameters:
- min_holes
- max_holes
- min_height
- max_height
- min_width
- max_width"
class InitSchema {
+num_holes_range: tuple[int, int]
+hole_height_range: tuple[ScalarType, ScalarType]
+hole_width_range: tuple[ScalarType, ScalarType]
}
note for InitSchema "Removed validation methods and
deprecated parameters"
CoarseDropout -- InitSchema
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
=========================================
+ Coverage 0 89.71% +89.71%
=========================================
Files 0 50 +50
Lines 0 9094 +9094
=========================================
+ Hits 0 8159 +8159
- Misses 0 935 +935 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Refactor the
CoarseDropout
transform by replacing deprecated parametersmin_holes
,max_holes
,min_height
,max_height
,min_width
, andmax_width
with the new parametersnum_holes_range
,hole_height_range
, andhole_width_range
respectively.Enhancements:
min_holes
,max_holes
,min_height
,max_height
,min_width
, andmax_width
parameters withnum_holes_range
,hole_height_range
, andhole_width_range
inCoarseDropout
.Tests:
CoarseDropout
.