Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CoarseDropout #2241

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updated CoarseDropout #2241

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Refactor the CoarseDropout transform by replacing deprecated parameters min_holes, max_holes, min_height, max_height, min_width, and max_width with the new parameters num_holes_range, hole_height_range, and hole_width_range respectively.

Enhancements:

  • Replace deprecated min_holes, max_holes, min_height, max_height, min_width, and max_width parameters with num_holes_range, hole_height_range, and hole_width_range in CoarseDropout.

Tests:

  • Remove tests for deprecated parameters in CoarseDropout.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request refactors the CoarseDropout class to replace deprecated parameters with updated range parameters. It removes min_holes, max_holes, min_height, max_height, min_width, and max_width and replaces them with num_holes_range, hole_height_range, and hole_width_range respectively. It also updates the default values of num_holes_range, hole_height_range, and hole_width_range, and removes corresponding validation logic and tests.

Class diagram showing changes to CoarseDropout class

classDiagram
    class CoarseDropout {
        -num_holes_range: tuple[int, int]
        -hole_height_range: tuple[ScalarType, ScalarType]
        -hole_width_range: tuple[ScalarType, ScalarType]
        -fill: DropoutFillValue
        -fill_mask: ColorType
        -p: float
        +__init__(num_holes_range=(1,2), hole_height_range=(0.1,0.2), hole_width_range=(0.1,0.2), fill=0, fill_mask=None, p=0.5)
    }
    note for CoarseDropout "Removed deprecated parameters:
    - min_holes
    - max_holes
    - min_height
    - max_height
    - min_width
    - max_width"

    class InitSchema {
        +num_holes_range: tuple[int, int]
        +hole_height_range: tuple[ScalarType, ScalarType]
        +hole_width_range: tuple[ScalarType, ScalarType]
    }
    note for InitSchema "Removed validation methods and
deprecated parameters"

    CoarseDropout -- InitSchema
Loading

File-Level Changes

Change Details Files
Replaced deprecated parameters with range parameters.
  • Removed min_holes, max_holes, min_height, max_height, min_width, and max_width parameters.
  • Introduced num_holes_range, hole_height_range, and hole_width_range parameters.
  • Updated default values for the new range parameters.
  • Removed validation logic for deprecated parameters.
  • Removed tests for deprecated parameters.
albumentations/augmentations/dropout/coarse_dropout.py
tests/test_transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tests/test_transforms.py Show resolved Hide resolved
@ternaus ternaus merged commit 327a6b2 into main Jan 7, 2025
14 checks passed
@ternaus ternaus deleted the update_coarse_dropout branch January 7, 2025 17:01
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (b1a79c2) to head (1fc05ef).
Report is 347 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2241       +/-   ##
=========================================
+ Coverage      0   89.71%   +89.71%     
=========================================
  Files         0       50       +50     
  Lines         0     9094     +9094     
=========================================
+ Hits          0     8159     +8159     
- Misses        0      935      +935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant