Updated Rotate

[ternaus]

Summary by Sourcery

Enhancements:

• Remove deprecated 'value' and 'mask_value' parameters in favor of 'fill' and 'fill_mask'.
• Changed default value for border mode from reflection to constant

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request removes deprecated parameters 'value' and 'mask_value' from the InitSchema class and their associated validation logic. Additionally, it changes the default 'border_mode' in the Rotate class constructor from cv2.BORDER_REFLECT_101 to cv2.BORDER_CONSTANT.

Class diagram showing changes to InitSchema class

classDiagram
    class InitSchema {
        +limit: ScaleFloatType
        +interpolation: int
        +border_mode: int
        +fill: ColorType
        +fill_mask: ColorType
        -value: ColorType [REMOVED]
        -mask_value: ColorType [REMOVED]
        -validate_value() [REMOVED]
    }
    note for InitSchema "Default border_mode changed to BORDER_CONSTANT"

Loading

File-Level Changes

Change	Details	Files
Removed deprecated parameters and their validation logic.	Removed 'value' and 'mask_value' parameters from the InitSchema class. Deleted the model_validator method that handled the deprecation warnings for 'value' and 'mask_value'.	albumentations/augmentations/geometric/rotate.py
Changed default border mode in the Rotate class constructor.	Updated the default value of 'border_mode' from cv2.BORDER_REFLECT_101 to cv2.BORDER_CONSTANT.	albumentations/augmentations/geometric/rotate.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• Changing the default border_mode from BORDER_REFLECT_101 to BORDER_CONSTANT is a breaking change that could negatively impact existing users. Please provide justification for this change or consider keeping the original default.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (b1a79c2) to head (80da98c).
Report is 351 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #2245       +/-   ##
=========================================
+ Coverage      0   89.79%   +89.79%     
=========================================
  Files         0       50       +50     
  Lines         0     9044     +9044     
=========================================
+ Hits          0     8121     +8121     
- Misses        0      923      +923     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.