Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Affine #2249

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updated Affine #2249

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Enhancements:

  • Replace deprecated parameters cval, cval_mask, and mode with fill, fill_mask, and border_mode in the Affine transform.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request removes deprecated arguments cval, cval_mask, and mode from the Affine transform. It replaces them with fill, fill_mask, and border_mode respectively. The validator logic that handled the deprecated arguments has also been removed.

Class diagram showing changes to InitSchema class

classDiagram
    class InitSchema {
        +interpolation: InterpolationType
        +mask_interpolation: InterpolationType
        +fill: ColorType
        +fill_mask: ColorType
        +border_mode: BorderModeType
    }
    note for InitSchema "Removed deprecated fields:
    - cval
    - cval_mask
    - mode
    Removed validator for deprecated fields"
Loading

File-Level Changes

Change Details Files
Removed deprecated arguments and their validation logic.
  • Removed cval, cval_mask, and mode arguments from the __init__ method.
  • Removed the model validator that handled the deprecated arguments and issued warnings.
  • Removed the deprecated arguments from the InitSchema.
albumentations/augmentations/geometric/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add information to the PR description about when these parameters were deprecated and whether this is part of a major version release.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (b1a79c2) to head (b4155a9).
Report is 355 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2249       +/-   ##
=========================================
+ Coverage      0   89.86%   +89.86%     
=========================================
  Files         0       50       +50     
  Lines         0     9011     +9011     
=========================================
+ Hits          0     8098     +8098     
- Misses        0      913      +913     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit d75c583 into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_affine branch January 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant