-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Affine #2249
Updated Affine #2249
Conversation
Reviewer's Guide by SourceryThis pull request removes deprecated arguments Class diagram showing changes to InitSchema classclassDiagram
class InitSchema {
+interpolation: InterpolationType
+mask_interpolation: InterpolationType
+fill: ColorType
+fill_mask: ColorType
+border_mode: BorderModeType
}
note for InitSchema "Removed deprecated fields:
- cval
- cval_mask
- mode
Removed validator for deprecated fields"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add information to the PR description about when these parameters were deprecated and whether this is part of a major version release.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=========================================
+ Coverage 0 89.86% +89.86%
=========================================
Files 0 50 +50
Lines 0 9011 +9011
=========================================
+ Hits 0 8098 +8098
- Misses 0 913 +913 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Enhancements:
cval
,cval_mask
, andmode
withfill
,fill_mask
, andborder_mode
in theAffine
transform.