Updated PadIfNeeded

[ternaus]

Summary by Sourcery

Enhancements:

• Replace deprecated value and mask_value parameters with fill and fill_mask respectively.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the PadIfNeeded transform by changing the default border_mode to cv2.BORDER_CONSTANT and updating the fill and fill_mask parameters accordingly. It also removes deprecated parameters value and mask_value, replacing them with fill and fill_mask, respectively.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Changed default border_mode to cv2.BORDER_CONSTANT and updated fill and fill_mask parameters.	Changed the default value of border_mode from cv2.BORDER_REFLECT_101 to cv2.BORDER_CONSTANT. Added fill and fill_mask parameters to the PadIfNeeded transform and tests. Updated tests to use fill and fill_mask parameters with the new default border_mode.	albumentations/augmentations/geometric/transforms.py tests/test_transforms.py
Removed deprecated parameters value and mask_value.	Removed value and mask_value parameters from the PadIfNeeded transform. Removed validation and warning logic related to value and mask_value parameters.	albumentations/augmentations/geometric/transforms.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• Changing the default border_mode from BORDER_REFLECT_101 to BORDER_CONSTANT is a breaking change. Please document this prominently in the changelog/release notes, or consider maintaining the old default behavior until the next major version.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}