Updated RandomShadow

[ternaus]

Summary by Sourcery

Remove deprecated num_shadows_lower and num_shadows_upper parameters from RandomShadow transform and update tests accordingly.

Enhancements:

• Replaced num_shadows_lower and num_shadows_upper with num_shadows_limit.

Tests:

• Updated tests to reflect the removal of deprecated parameters.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the deprecated num_shadows_lower and num_shadows_upper parameters from the RandomShadow transform and updates the tests accordingly.

Class diagram showing changes to RandomShadow transform

classDiagram
    class InitSchema {
        +shadow_roi: tuple[float, float, float, float]
        +num_shadows_limit: tuple[int, int]
        -num_shadows_lower: int [REMOVED]
        -num_shadows_upper: int [REMOVED]
        +shadow_dimension: int
        +shadow_intensity_range: tuple[float, float]
        +validate_shadows()
    }
    note for InitSchema "Removed deprecated parameters
now using num_shadows_limit only"

Loading

File-Level Changes

Change	Details	Files
Removed deprecated num_shadows_lower and num_shadows_upper parameters	Removed the num_shadows_lower and num_shadows_upper parameters from the RandomShadow transform's initialization and schema. Removed the validation and warning logic related to these deprecated parameters. Updated the type hints and docstrings to reflect the removal of these parameters. Simplified the logic for handling the number of shadows by directly using num_shadows_limit.	albumentations/augmentations/transforms.py
Updated tests to reflect parameter removal	Removed the test cases that specifically checked for deprecation warnings related to num_shadows_lower and num_shadows_upper. Modified existing test cases to use only num_shadows_limit for controlling the number of shadows. Ensured that the tests cover the expected behavior with the simplified shadow generation logic.	tests/test_transforms.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• The removal of shadow_intensity_range validation code needs justification. This validation was ensuring values stayed within [0,1] range and checking types. Has this validation been moved elsewhere, or how are these constraints now being enforced?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (b1a79c2) to head (97ad728).
Report is 367 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #2261       +/-   ##
=========================================
+ Coverage      0   89.86%   +89.86%     
=========================================
  Files         0       50       +50     
  Lines         0     8876     +8876     
=========================================
+ Hits          0     7976     +7976     
- Misses        0      900      +900     

Flag	Coverage Δ
ubuntu-py3.12	89.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.