feat: add alchemy transport update for the mav2 account client #1271

Blu-J · 2025-01-10T20:26:14Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR introduces a new type NotType for type safety in TypeScript and modifies various client functions to ensure that specific transport types are not used with certain clients. It also adds tests for the createSMAV2AccountClient function, ensuring proper behavior with Alchemy transport.

Detailed summary

Added NotType type to enforce type constraints.
Updated parameters in createLightAccountClient, createMultiOwnerLightAccountClient, createMultiOwnerModularAccountClient, and createMultisigModularAccountClient to use NotType.
Added tests for createSMAV2AccountClient to validate Alchemy transport behavior.
Enhanced createSMAV2AccountClient to differentiate between Alchemy and custom transports.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-01-10T20:26:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 5:31pm
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 5:31pm

Blu-J · 2025-01-10T20:26:33Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

moldy530

couple nits and just some questions for my own understanding but overall LGTM

We should probs also test the types at a minimum that with AlchemyTransport we get an Alchemy client and any other transport we get a non Alchemy Client

account-kit/smart-contracts/src/ma-v2/client/client.ts

moldy530 · 2025-01-10T20:46:13Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

@@ -64,7 +97,21 @@ export function createSMAV2AccountClient<
 */
 export async function createSMAV2AccountClient(
  config: CreateSMAV2AccountClientParams
-): Promise<SmartAccountClient> {
+): Promise<SmartAccountClient | AlchemySmartAccountClient> {


for my own understanding: does it complain if this is just SmartAccountClient? technically the AlchemySmartAccountClient is a SmartAccountClient

No, just was being redundant. Good catch

Blu-J · 2025-01-13T16:37:54Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

+  TSigner extends SmartAccountSigner = SmartAccountSigner
+>(
+  args: CreateSMAV2AccountClientParams<TTransport, TChain, TSigner> &
+    NotType<TTransport, AlchemyTransport>


📓 So, this here was needed for the test to make sure that we didn't filter on the type alchemyTransport for the other case
Edit: W/O fix

Blu-J · 2025-01-13T16:39:35Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

+  Omit<
+    AlchemySmartAccountClientConfig<TChain, LightAccount<TSigner>>,
+    "account"
+  > & { paymasterAndData?: never };


📓 That without this this test fails

oh nice, I think we also need to add dummyPaymasterAndData?: never here as well

moldy530

had one comment, but LGTM otherwise!

moldy530 · 2025-01-13T16:53:57Z

account-kit/smart-contracts/src/ma-v2/client/client.ts

+  Omit<
+    AlchemySmartAccountClientConfig<TChain, LightAccount<TSigner>>,
+    "account"
+  > & { paymasterAndData?: never };


oh nice, I think we also need to add dummyPaymasterAndData?: never here as well

graphite-app · 2025-01-13T17:17:47Z

Merge activity

Jan 13, 12:17 PM EST: A user added this pull request to the Graphite merge queue.
Jan 13, 12:32 PM EST: A user merged this pull request with the Graphite merge queue.

# Pull Request Checklist - [x] Did you add new tests and confirm existing tests pass? (`yarn test`) - [x] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?  --- ## PR-Codex overview This PR introduces a new type `NotType` to prevent certain type extensions and modifies various client creation functions to utilize this type. It also enhances test coverage for the `createSMAV2AccountClient` function to validate transport behavior and policy ID specifications. ### Detailed summary - Added `NotType` type to prevent type extensions. - Updated `createLightAccountClient`, `createMultiOwnerLightAccountClient`, `createMultiOwnerModularAccountClient`, and `createMultisigModularAccountClient` to use `NotType`. - Enhanced tests for `createSMAV2AccountClient` to check behavior with `AlchemyTransport`. - Added tests for policy ID and paymaster restrictions in `createSMAV2AccountClient`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

This was referenced Jan 10, 2025

feat(client): multi account light and alchemy consolidation #1264

Merged

feat(aa-sdk): sdk light client can call the alchemy client #1236

Merged

test(test-d): add test-d files for vitest typechecking: #1248

Merged

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 20:37 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 20:39 View deployment

Blu-J force-pushed the 01-07-feat_client_multi_account_light_and_alchemy_consolidation branch from d05051e to b677351 Compare January 10, 2025 20:44

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 0bbe272 to 05a7dca Compare January 10, 2025 20:44

moldy530 reviewed Jan 10, 2025

View reviewed changes

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 20:55 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 20:58 View deployment

Blu-J force-pushed the 01-07-feat_client_multi_account_light_and_alchemy_consolidation branch from b677351 to d05051e Compare January 10, 2025 21:15

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 05a7dca to acc1708 Compare January 10, 2025 21:15

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 21:27 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 21:29 View deployment

Blu-J force-pushed the 01-07-feat_client_multi_account_light_and_alchemy_consolidation branch from d05051e to bfde6c0 Compare January 10, 2025 22:32

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from acc1708 to b826ba0 Compare January 10, 2025 22:33

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 22:44 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 22:46 View deployment

Blu-J force-pushed the 01-07-feat_client_multi_account_light_and_alchemy_consolidation branch from bfde6c0 to 136cc8f Compare January 10, 2025 22:51

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from b826ba0 to 73e0725 Compare January 10, 2025 22:51

vercel bot deployed to Preview – aa-sdk-ui-demo January 10, 2025 23:03 View deployment

vercel bot deployed to Preview – aa-sdk-site January 10, 2025 23:05 View deployment

Blu-J force-pushed the 01-07-feat_client_multi_account_light_and_alchemy_consolidation branch from 136cc8f to 5d46490 Compare January 10, 2025 23:53

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 73e0725 to 60ebd5f Compare January 10, 2025 23:53

vercel bot deployed to Preview – aa-sdk-ui-demo January 11, 2025 00:03 View deployment

vercel bot deployed to Preview – aa-sdk-site January 11, 2025 00:06 View deployment

Blu-J changed the base branch from 01-07-feat_client_multi_account_light_and_alchemy_consolidation to graphite-base/1271 January 11, 2025 00:39

Blu-J force-pushed the graphite-base/1271 branch from 5d46490 to 18a9228 Compare January 11, 2025 00:52

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 429ecb6 to c198db3 Compare January 13, 2025 16:34

Blu-J marked this pull request as ready for review January 13, 2025 16:35

Blu-J requested review from rthomare, dancoombs, mokok123, dphilipson, linnall, adamegyed, howydev, Zer0dot and jaypaik as code owners January 13, 2025 16:35

Blu-J commented Jan 13, 2025

View reviewed changes

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch 2 times, most recently from f6eb7cb to 272e944 Compare January 13, 2025 16:49

moldy530 previously approved these changes Jan 13, 2025

View reviewed changes

Blu-J dismissed moldy530’s stale review via 6e94f2c January 13, 2025 16:55

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 272e944 to 6e94f2c Compare January 13, 2025 16:55

moldy530 approved these changes Jan 13, 2025

View reviewed changes

vercel bot deployed to Preview – aa-sdk-ui-demo January 13, 2025 17:07 View deployment

vercel bot deployed to Preview – aa-sdk-site January 13, 2025 17:17 View deployment

Blu-J force-pushed the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch from 6e94f2c to 71089c4 Compare January 13, 2025 17:18

vercel bot deployed to Preview – aa-sdk-ui-demo January 13, 2025 17:28 View deployment

vercel bot deployed to Preview – aa-sdk-site January 13, 2025 17:31 View deployment

graphite-app bot merged commit 71089c4 into main Jan 13, 2025
8 checks passed

graphite-app bot deleted the 01-10-feat_add_alchemy_transport_update_for_the_mav2_account_client branch January 13, 2025 17:32

vercel bot deployed to Production – aa-sdk-ui-demo January 13, 2025 17:43 View deployment

vercel bot deployed to Production – aa-sdk-site January 13, 2025 17:46 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add alchemy transport update for the mav2 account client #1271

feat: add alchemy transport update for the mav2 account client #1271

Blu-J commented Jan 10, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 10, 2025 •

edited

Loading

Blu-J commented Jan 10, 2025 •

edited

Loading

moldy530 left a comment

moldy530 Jan 10, 2025

Blu-J Jan 13, 2025

Blu-J Jan 13, 2025 •

edited

Loading

Blu-J Jan 13, 2025

moldy530 Jan 13, 2025

moldy530 left a comment

moldy530 Jan 13, 2025

graphite-app bot commented Jan 13, 2025 •

edited

Loading

feat: add alchemy transport update for the mav2 account client #1271

feat: add alchemy transport update for the mav2 account client #1271

Conversation

Blu-J commented Jan 10, 2025 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Jan 10, 2025 • edited Loading

Blu-J commented Jan 10, 2025 • edited Loading

How to use the Graphite Merge Queue

moldy530 left a comment

Choose a reason for hiding this comment

moldy530 Jan 10, 2025

Choose a reason for hiding this comment

Blu-J Jan 13, 2025

Choose a reason for hiding this comment

Blu-J Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

Blu-J Jan 13, 2025

Choose a reason for hiding this comment

moldy530 Jan 13, 2025

Choose a reason for hiding this comment

moldy530 left a comment

Choose a reason for hiding this comment

moldy530 Jan 13, 2025

Choose a reason for hiding this comment

graphite-app bot commented Jan 13, 2025 • edited Loading

Merge activity

Blu-J commented Jan 10, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 10, 2025 •

edited

Loading

Blu-J commented Jan 10, 2025 •

edited

Loading

Blu-J Jan 13, 2025 •

edited

Loading

graphite-app bot commented Jan 13, 2025 •

edited

Loading