Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Incrementals - Calendar Event Delta Handling #2022

Closed
Tracked by #1777
ryanfkeepers opened this issue Jan 3, 2023 · 1 comment
Closed
Tracked by #1777

Incrementals - Calendar Event Delta Handling #2022

ryanfkeepers opened this issue Jan 3, 2023 · 1 comment
Assignees

Comments

@ryanfkeepers
Copy link
Contributor

Issue

Delta coverage for calendar events is incomplete.

Events vs Views

The Calendar Event object stored by Corso does not support delta queries. There is an alternative event object, the Calendar View, which is (quoting the docs) "a set of event resources that have been added, deleted, or updated in a calendarView (a range of events defined by start and end dates)". It's possible that Corso should store both types.

Lazy Event Pulling

Since the primary event set does not have delta support, we may have to find alternative ways to minimize data retrieval. One option is a lazy pull: only perform the full item download if the item's modTime has changed between kopia and GC.

@ashmrtn
Copy link
Contributor

ashmrtn commented Jan 3, 2023

@ryanfkeepers ryanfkeepers self-assigned this Jan 17, 2023
aviator-app bot pushed a commit that referenced this issue Jan 19, 2023
## Description

Hacks the beta version call into the events api
when iterating through items, allowing us to run
delta-based queries for calendar events.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #2022

## Test Plan

- [x] ⚡ Unit test
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 19, 2023
## Description

CI Secrets will need to be updated to complete this change.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🤖 Test
- [x] 💻 CI/Deployment

## Issue(s)

* #2022

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 19, 2023
## Description

Adds a little extra process into the calendar
resolver so that it mimics the mail and contact
resolvers.  This will allow us to collapse the
three resolvers into a more common handler
or interface.

We can take this change or drop it.  I added
the code in exploration of the event test failures,
and figured I'd throw it out just in case.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🧹 Tech Debt/Cleanup

## Issue(s)

* #2022

## Test Plan

- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 23, 2023
## Description

Fixes and unskips the tests incremental integration tests
for exchange calendar events.

Currently blocked on LynneR displaying the calendar
fetch issues where it's only possible to retrieve her default
Calendar, Birthdays, and US Holidays calendars.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🤖 Test

## Issue(s)

* #2022

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 30, 2023
## Description

Minor refactor that came up while hunting bugs.
For the life of me, I cannot find the reason for
read/write counts being off in event incrementals.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🧹 Tech Debt/Cleanup

## Issue(s)

* #2022

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
meain pushed a commit that referenced this issue Jan 31, 2023
## Description

Minor refactor that came up while hunting bugs.
For the life of me, I cannot find the reason for
read/write counts being off in event incrementals.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🧹 Tech Debt/Cleanup

## Issue(s)

* #2022

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants