This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Log to disk by default #2076
Assignees
Comments
This was referenced Jan 10, 2023
Merged
aviator-app bot
pushed a commit
that referenced
this issue
Jan 13, 2023
## Description This changes the behavior of logs and writes it to disk instead of `stdout` by default. It also adds a new flag `--log-file` to specify the filename for the log file. ## Does this PR need a docs update or release note? - [x] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [ ] ⛔ No ## Type of change <!--- Please check the type of change your PR introduces: ---> - [x] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [ ] 💻 CI/Deployment - [ ] 🧹 Tech Debt/Cleanup ## Issue(s) <!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. --> * fixes #2076 ## Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currents logs are pushed to stdout by default. This clashes with the progressbar as well. Also, when logging to file we can add more info than just the bare minimum as the user does not see it.
TBD
$PWD/corso-<datetime>.logor$HOME/.corso/<datetime>.logor/var/log/corso/<datetime>.log)--log-file /tmp/corso.log)--log-file -)The text was updated successfully, but these errors were encountered: