Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

pass last modified time from graph connector to kopia wrapper #622

Closed
Tracked by #547
ashmrtn opened this issue Aug 19, 2022 · 0 comments · Fixed by #1670
Closed
Tracked by #547

pass last modified time from graph connector to kopia wrapper #622

ashmrtn opened this issue Aug 19, 2022 · 0 comments · Fixed by #1670
Assignees

Comments

@ashmrtn
Copy link
Contributor

ashmrtn commented Aug 19, 2022

Simplest solution is likely to extend the data.Stream interface with a ModTime() time.Time function. GraphConnector will then need to fetch that information when contacting Graph API and populate that struct field

@ashmrtn ashmrtn self-assigned this Sep 22, 2022
aviator-app bot pushed a commit that referenced this issue Dec 5, 2022
## Description

Add ModTime to Exchange, OneDrive and SharePoint list stream items. This enables kopia-assisted incrementals for those items. Backup details still contains a complete set of information for all items in the backup regardless of if kopia uploaded data for the item or not.

Kopia-assisted incrementals does come with some caveats though. If changes are made to an item in M365 and that change does not cause the modified time reported by M365 to update, then the change will not be backed up. Currently, only marking an email as read/unread is known to hit this edge case.

This patch does not lazily fetch data from Graph API. This means that kopia may upload less data, but the same amount of data will still be pulled from Graph

## Type of change

- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

* closes #622 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [ ] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant