This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Set file mod time in KopiaWrapper #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmrtn
added
enhancement
ryanfkeepers
approved these changes
Oct 31, 2022
Comment on lines
+51
to
+52
| // StreamModTime is used to provide the modified time of the stream's data. | ||
| type StreamModTime interface { |
There was a problem hiding this comment.
Nit: slightly more in keeping with go interface naming convention.
Suggested change
| // StreamModTime is used to provide the modified time of the stream's data. | |
| type StreamModTime interface { | |
| // ModTimer is used to provide the modified time of the stream's data. | |
| type ModTimer interface { |
There was a problem hiding this comment.
hmmm actually now that I look at it more, can we hold off on this. I wanted to keep it consistent with some of the other interfaces defined in the file (StreamSize, StreamInfo). I think either we should change all of them in a different patch or leave them all consistency
ashmrtn
force-pushed
the
621-kopia-streaming-file-mod-time
branch
from
dff9f33 to
55df307
Compare
ashmrtn
force-pushed
the
1404-kopia-use-prev-snapshots
branch
from
c3d3fbc to
b6be41f
Compare
Mod times allow kopia to skip uploading files it's previously uploaded (assuming they haven't changed), so providing this information to it is useful.
Mostly useful for testing, but could be reported to the user as well.
* default mod time for exchange mock connector item to the current time (preserve current behavior as long as items are not re-used) * expand backup test to test for caching
ashmrtn
force-pushed
the
621-kopia-streaming-file-mod-time
branch
from
55df307 to
6979e84
Compare
Aviator status
This PR was merged using Aviator. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the mod time of uploaded files to either the mod time of the item (if it has one) or the current time (if it does not have one). Also add tests to check caching in kopia works properly.
Type of change
Issue(s)
StreamingFiles #621part of:
merge after:
Test Plan