Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Do not return an error if folder was deleted #1849

Merged
merged 4 commits into from
Dec 17, 2022
Merged

Do not return an error if folder was deleted #1849

merged 4 commits into from
Dec 17, 2022

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Dec 16, 2022 •
edited
Loading

Description

When backing up Exchange, don't return an error if the folder/calendar we're trying to fetch item IDs for has been deleted.

Error codes pulled with graph explorer API

Manually tested with an Exchange mail backup

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn
Do not return an error if folder was deleted
9aaa680 
When backing up Exchange, don't return an error if the folder/calendar
we're trying to fetch item IDs for has been deleted.
@ashmrtn ashmrtn added the bug Something isn't working label Dec 16, 2022
@ashmrtn ashmrtn self-assigned this Dec 16, 2022
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 21:20 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 21:20 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 21:20 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 21:21 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 21:21 — with GitHub Actions Inactive
dadams39
dadams39 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@dadams39 dadams39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

@ashmrtn
Return error and check in caller
c15c2cc 
Return an error if the folder was deleted and check return status in the
caller. Also add some logic so that it will work seamlessly when we need
to start reporting the new state of directories for incremental backups.
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:36 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:36 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:36 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:37 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:37 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 22:37 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 16, 2022 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot temporarily deployed to Testing December 16, 2022 23:14 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 16, 2022 23:14 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 16, 2022 23:15 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 16, 2022 23:15 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing December 16, 2022 23:15 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Dec 16, 2022
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 16, 2022

PR failed to merge with reason: some CI status(es) failed.
Failed CI(s): Test-Suite-Trusted

@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Dec 16, 2022
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
8.8% 8.8% Duplication

@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 16, 2022 23:45 — with GitHub Actions Inactive
@aviator-app aviator-app bot merged commit 715e436 into main Dec 17, 2022
@aviator-app aviator-app bot deleted the 1846-err-folder-sync branch December 17, 2022 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

@dadams39 dadams39 dadams39 approved these changes

@vkamra vkamra Awaiting requested review from vkamra

Assignees

@ashmrtn ashmrtn

Labels
bug Something isn't working mergequeue-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exchange backup failed with ErrorSyncFolderNotFound errors
3 participants
@ashmrtn @dadams39 @ryanfkeepers