Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

use selector owners, not scope owners #1890

Merged
merged 7 commits into from
Jan 4, 2023
Merged

use selector owners, not scope owners #1890

merged 7 commits into from
Jan 4, 2023

Conversation

ryanfkeepers
Copy link
Contributor

Description

Migrates code away from pulling the resource
owner from each scope, and instead usees the
selector as the canon identifier of the resource
owner.

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

Test Plan

  • ⚡ Unit test
  • 💚 E2E

@ryanfkeepers ryanfkeepers added the enhancement New feature or request label Dec 20, 2022
@ryanfkeepers ryanfkeepers requested a review from ashmrtn December 20, 2022 23:55
@ryanfkeepers ryanfkeepers self-assigned this Dec 20, 2022
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 20, 2022 23:55 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 20, 2022 23:55 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 20, 2022 23:55 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 20, 2022 23:56 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers added the blocked Upstream item prevents completion label Dec 21, 2022
@ryanfkeepers ryanfkeepers force-pushed the issue-1617-3-useselectorowners branch from aaece9b to 6e87ad3 Compare January 3, 2023 20:06
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 20:06 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 20:06 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 20:06 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 20:07 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 20:07 — with GitHub Actions Inactive
Base automatically changed from issue-1617-discrete to main January 3, 2023 20:55
@ryanfkeepers ryanfkeepers force-pushed the issue-1617-3-useselectorowners branch from 6e87ad3 to 8328480 Compare January 3, 2023 22:15
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 22:16 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 22:16 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers removed the blocked Upstream item prevents completion label Jan 3, 2023
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 22:16 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 22:16 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 3, 2023 22:16 — with GitHub Actions Inactive
@ryanfkeepers
Copy link
Contributor Author

@ashmrtn this is now ready for review

ashmrtn
ashmrtn approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ashmrtn ashmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make a follow-up PR at some point that removes data.ResouceOwnerSet() and just uses either a hard-coded value or some other way to determine the number of resource owners for the operation

src/internal/connector/exchange/data_collections.go Show resolved Hide resolved
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 17:38 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 17:38 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 17:39 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.4% 16.4% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 17:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 17:39 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Jan 4, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 4, 2023

PR failed to merge with reason: some CI status(es) failed.
Failed CI(s): Test-Suite-Trusted

@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Jan 4, 2023
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 18:57 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 18:57 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 18:57 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 18:57 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 18:57 — with GitHub Actions Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:17 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:17 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.4% 10.4% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:17 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 19:18 Inactive
@aviator-app aviator-app bot merged commit 0d0a751 into main Jan 4, 2023
@aviator-app aviator-app bot deleted the issue-1617-3-useselectorowners branch January 4, 2023 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmrtn ashmrtn ashmrtn approved these changes

Assignees

@ryanfkeepers ryanfkeepers

Labels
enhancement New feature or request mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanfkeepers @ashmrtn