Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Lift'n'shift of existing code #1925

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Lift'n'shift of existing code #1925

merged 1 commit into from
Dec 22, 2022

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Dec 22, 2022

Description

Factor out code to get a set of FolderEntries based on some path information. This code will be used in BackupOp when merging item details.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn ashmrtn self-assigned this Dec 22, 2022
Factor out code to get a set of FolderEntries based on some path
information. This code will be used in BackupOp when merging item
details.
@ashmrtn ashmrtn force-pushed the 1800-details-folder-helper branch from e91657b to 2124f7b Compare December 22, 2022 23:27
@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:27 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:27 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:28 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:28 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:28 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 22, 2022 23:28 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 22, 2022

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot merged commit 04851f4 into main Dec 22, 2022
@aviator-app aviator-app bot deleted the 1800-details-folder-helper branch December 22, 2022 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants