Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fix --users "*' not finding user in tenant #2033

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

ryanfkeepers
Copy link
Contributor

Description

DataCollections validation step was still using the full resourceOwner list in the selector to validate every backup, rather than checking only the DiscreteOwner.

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🐛 Bugfix

Issue(s)

Test Plan

  • ⚡ Unit test

DataCollections validation step was still using the full
resourceOwner list in the selector to validate every
backup, rather than checking only the DiscreteOwner.
@ryanfkeepers ryanfkeepers added the bug Something isn't working label Jan 4, 2023
@ryanfkeepers ryanfkeepers requested a review from ashmrtn January 4, 2023 23:09
@ryanfkeepers ryanfkeepers self-assigned this Jan 4, 2023
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 23:09 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 23:09 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 23:10 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 23:10 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 4, 2023 23:10 — with GitHub Actions Inactive
@ryanfkeepers
Copy link
Contributor Author

Manual run result:

Started At            ID                                    Status                Selectors                        
  2023-01-04T23:02:13Z  93e03272-fe30-4e4f-a001-7f8af3165977  Completed (0 errors)  [email protected]    
  2023-01-04T23:02:19Z  1356a213-3d59-40ce-b6a6-0c003e3cf3df  Completed (0 errors)  [email protected]     
  2023-01-04T23:02:26Z  a34dd62b-0b7e-47eb-962d-5af6ab669642  Completed (0 errors)  [email protected]  
  2023-01-04T23:02:32Z  487fc0e4-2dc9-45ca-bf6d-0b5bbacf1338  Completed (0 errors)  [email protected]
  2023-01-04T23:02:37Z  617a6040-77a9-4c3b-8d14-21bb619ff77d  Completed (0 errors)  [email protected]    
  2023-01-04T23:02:43Z  98df605e-5d46-4e3e-a9db-9b576f62fc01  Completed (0 errors)  [email protected]   
  2023-01-04T23:02:49Z  f5927c33-b85d-4bc0-b182-f1c279e805b6  Completed (0 errors)  [email protected]
  2023-01-04T23:02:56Z  7f75228e-6a44-4a50-9a5f-c9a6b97595b2  Completed (0 errors)  [email protected]    
  2023-01-04T23:03:04Z  cd5a4c0c-dddf-4467-bf94-73dfca394d77  Completed (0 errors)  [email protected]
  2023-01-04T23:03:13Z  88c535ca-0788-4dbb-a207-82a6e51db488  Completed (0 errors)  [email protected]
  2023-01-04T23:03:20Z  0ace2a9c-9a93-4663-b5f8-c6e898945cf5  Completed (0 errors)  [email protected]   
  2023-01-04T23:03:27Z  fc968a5f-9898-4033-8ed6-2899888e4fed  Completed (0 errors)  [email protected]  
  2023-01-04T23:04:44Z  a6d268cb-a41d-49a8-9751-d57aedfc4ecc  Completed (0 errors)  [email protected]     
  2023-01-04T23:04:53Z  53a4287d-0425-4c70-b226-d94eb54eccf5  Completed (0 errors)  [email protected]      
  2023-01-04T23:08:21Z  3ac9991d-7b00-47d1-90b9-c32609947feb  Completed (0 errors)  [email protected]    
  2023-01-04T23:08:30Z  d1522397-0f0c-4deb-b532-7d914fc7a9af  Completed (0 errors)  [email protected]    
  2023-01-04T23:08:58Z  334e69a0-e651-410e-8e41-fa463b6e4c3b  Completed (0 errors)  [email protected]    
  2023-01-04T23:09:06Z  f9b3803f-ddd7-49cc-89d0-6e96ce6053c4  Completed (0 errors)  [email protected]   
  2023-01-04T23:09:12Z  76e6e592-b0c8-4b97-a5c5-b303ef34b1a2  Completed (0 errors)  [email protected]   
  2023-01-04T23:09:18Z  f94c7de2-f7f5-43cb-bc39-b3dd7c33ff9d  Completed (0 errors)  [email protected]     
  2023-01-04T23:09:23Z  871c9790-b070-4197-9643-91b39d3ed2b2  Completed (0 errors)  [email protected]    
  2023-01-04T23:09:28Z  c8fbd16a-1986-4722-a3f0-5c605ce2b18b  Completed (0 errors)  [email protected]  
  2023-01-04T23:09:34Z  718677aa-5ec9-479d-a035-4aa3d58cc14e  Completed (0 errors)  [email protected]  
  2023-01-04T23:09:43Z  841b61ef-6348-4729-acdf-00475ec62fa0  Completed (0 errors)  [email protected]
  2023-01-04T23:09:48Z  c8c7414c-9c89-4195-ae0e-3012f305f679  Completed (0 errors)  [email protected]  
  2023-01-04T23:09:52Z  19b0b768-a1ce-45cf-97b4-bf5304bbd798  Completed (0 errors)  [email protected]    

Copy link
Contributor

@ashmrtn ashmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing. We need to find a way to test this automatically though, otherwise we'll probably keep hitting issues

@ryanfkeepers
Copy link
Contributor Author

otherwise we'll probably keep hitting issues

Hah! I mean, hopefully not. But, you know.

Either load testing or smoke testing are the most appropriate ways to keep this tested. But, well, one set is down, and the other doesn't exist. Those will need some attention soon.

@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 5, 2023

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing January 5, 2023 00:02 — with GitHub Actions Inactive
@aviator-app aviator-app bot merged commit edc4426 into main Jan 5, 2023
@aviator-app aviator-app bot deleted the issue-1617-starfix branch January 5, 2023 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working mergequeue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants