MetaData: Pages Backup Info Support #2084
Conversation
SharePointInfo method for SitePageable objects. Test suite included.
| // sharePointPageInfo propagates metadata from the SharePoint Page data type | ||
| // into searchable content. | ||
| // Page Details: https://learn.microsoft.com/en-us/graph/api/resources/sitepage?view=graph-rest-beta | ||
| func sharePointPageInfo(page bmodel.SitePageable, size int64) *details.SharePointInfo { |
There was a problem hiding this comment.
This isn't getting called outside of tests, making it effectively dead code. What's the plan for using it?
Also, we're a little weird on package sharing here, but is there any way to combine or co-locate this with the other sharePointItemInfo? It's true, it doesn't really belong in that package. But until we refactor things towards interface compliance (my fault for not starting things off that way), I assume that the info you're looking for will need to be retrieved within that process.
There was a problem hiding this comment.
Issue #2071 is to refactor SharePoint into 3 distinct items similar to exchange.
- Pages
- Lists
- Libraries
This will constitute a site being effectively backed up. Not USED here; however, it was the quickest way to verify library complications for using a single library frommsgraph-beta-sdk-go
There was a problem hiding this comment.
For completion of issue #2072, the SharePoint.Page will be placed outside of the onedrive.
…#2088) ## Description Imports minimal version of `site_page.go` and `site_pageable.go` to avoid compile time failures for `msgraph-beta-sdk-go`.
Removal of alias from
Aviator status
This PR was merged using Aviator. |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
SharePointInfo extended to include SitePageable objects.
NOTE: Merge includes the beta graph package and will affect the compile time.
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan