Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

GC: SharePoint: BackUp: Pages #2178

Merged
merged 151 commits into from
Feb 3, 2023
Merged

GC: SharePoint: BackUp: Pages #2178

merged 151 commits into from
Feb 3, 2023

Conversation

dadams39
Copy link
Contributor

@dadams39 dadams39 commented Jan 19, 2023 •
edited
Loading

Description

  • Adds logic to retrieve SharePoint.Pages from M365
  • Anchor PR for SharePoint.Pages feature support. Restore Pipeline
    PR to remain in Draft to ensure PR Train is stable until the solution to GC: Add Beta Servicer feature #2174 is implemented.

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

Test Plan

  • ⚡ Unit test

NOTE: Tests will fail in CI due to complications with #2086.

@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:25 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:25 — with GitHub Actions Inactive
@dadams39 dadams39 marked this pull request as draft January 19, 2023 05:25
@dadams39 dadams39 self-assigned this Jan 19, 2023
@dadams39 dadams39 added the enhancement New feature or request label Jan 19, 2023
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:34 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:34 — with GitHub Actions Inactive
@dadams39
Updates to site_page.go
764909e 
Removes minimal definition of SitePages from page.
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:36 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 05:36 — with GitHub Actions Inactive
@dadams39
Updates to /sharepoint/site_page.go
ec613b6 
Adds logic for fetching Page M365 IDs.
@dadams39
Update /sharepoint/data_collections.g
f5326c0 
Adds function collectPages() to logic of dataCollections.
@dadams39
Update to /connector/sharepoint/collection.go
bbf3370 
Adds field to hold Beta service within struct for populate method.
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 06:32 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing January 19, 2023 06:32 — with GitHub Actions Inactive
@dadams39
Updates to /connector/sharepoint/collection_test.go
7846c99 
Code clean-up. Use of constants and setup suite.
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:15 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:15 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:16 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:16 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:16 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 16:16 — with GitHub Actions Inactive
@dadams39
Movement of /connector/sharepoint/site_page* to /sharepoint/api package
20733bb
@dadams39
New file created /connector/sharepoint/api/api.go
1f561d6 
API to hold common structs and functions.
@dadams39
Create new file /sharepoint/api/helper_test.go
cc865e0 
Helper functions for tests added to package.
@dadams39
Updates to /sharepoint/helper_test.go
c00b7cf 
Moves beta test functions to the api package.
@dadams39
Updates to /connector/sharepoint/data_collections.go
a088da7 
Updates struct fields for usage, libraries, and updates for usage of api directory.
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 18:09 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 18:09 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 18:09 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 18:09 — with GitHub Actions Inactive
@dadams39 dadams39 temporarily deployed to Testing February 3, 2023 18:09 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Feb 3, 2023 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:17 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:17 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:17 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing February 3, 2023 18:18 Inactive
@aviator-app aviator-app bot merged commit 6e12885 into main Feb 3, 2023
@aviator-app aviator-app bot deleted the backup-page-flow branch February 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@dadams39 dadams39

Labels
backup enhancement New feature or request mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadams39 @ryanfkeepers