This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
GC: SharePoint: Backup: Abstract / Serialize #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Beta library for pages.
Removes minimal definition of SitePages from page.
Adds logic for fetching Page M365 IDs.
Adds function collectPages() to logic of dataCollections.
Adds field to hold Beta service within struct for populate method.
Increases swap space for build.
Troubleshooting
Troubleshooting passed 8 GB.
Adds abstraction to the backup process.
Adds new identifier to NewCollection() call
Adds new identifier to NewCollection() call
ryanfkeepers
approved these changes
Feb 6, 2023
Comments removed.
Collection test for Pages added.
Updates to consolidate TestCollection_Items into table format.
Aviator status
This PR was merged using Aviator. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes address updates to
sharePoint.Collection.Populate().ListsandPages. Drives are supported in OneDrive at this time.Pages.Collection needs to support List and Pages support. Additionally, needs to use a similar interface as in
exchangeto ensure retry and async collection populationDoes this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan
Test can be completed locally. Per Issue #2086, the Beta library interferes with overall caching.
TestSharePointPageCollection_Populate()inspects changes