Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Record graph error #2195

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Record graph error #2195

merged 3 commits into from
Jan 20, 2023

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Jan 20, 2023

Description

Record information about the error Graph returned if something went wrong when fetching an item.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn
Record graph error
24a1ec0 
Record information about the error Graph returned if something went
wrong when fetching an item.
@ashmrtn ashmrtn added bug Something isn't working supportability labels Jan 20, 2023
@ashmrtn ashmrtn self-assigned this Jan 20, 2023
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:51 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:51 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:52 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:52 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:52 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 01:52 — with GitHub Actions Inactive
rajatkateja
rajatkateja approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@rajatkateja rajatkateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 04:19 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 04:19 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 04:19 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 20, 2023 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 04:19 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 04:19 — with GitHub Actions Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Jan 20, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 20, 2023

PR failed to merge with reason: merge conflict detected, please resolve manually and requeue.
Additional debug info: Failed to merge changes from the base branch into this PR. You will probably need to merge the latest changes from the base branch into the PR branch and manually resolve conflicts).

@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Jan 20, 2023
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:15 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:15 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:15 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:16 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:16 — with GitHub Actions Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Jan 20, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 20, 2023

PR failed to merge with reason: some CI status(es) failed.
Failed CI(s): Test-Suite-Trusted

@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 20, 2023 05:34 — with GitHub Actions Inactive
@aviator-app aviator-app bot removed the blocked Upstream item prevents completion label Jan 20, 2023
@aviator-app aviator-app bot merged commit 5d20e30 into main Jan 20, 2023
@aviator-app aviator-app bot deleted the 2194-data-col-errors branch January 20, 2023 05:55
@ryanfkeepers ryanfkeepers mentioned this pull request May 13, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rajatkateja rajatkateja rajatkateja approved these changes

@vkamra vkamra Awaiting requested review from vkamra

@ryanfkeepers ryanfkeepers Awaiting requested review from ryanfkeepers

Assignees

@ashmrtn ashmrtn

Labels
bug Something isn't working mergequeue supportability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph error not recorded when fetching exchange items
2 participants
@ashmrtn @rajatkateja