Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Transaction shipping cost set twice #32

Closed
devon-o opened this issue Feb 13, 2014 · 1 comment
Closed

Transaction shipping cost set twice #32

devon-o opened this issue Feb 13, 2014 · 1 comment
Assignees
Labels

Comments

@devon-o
Copy link

devon-o commented Feb 13, 2014

Hello alebianco,

I haven't actually used this ane yet, but it looks quite nice and I thank you for releasing it.

However, while looking over the code to see how it works, I noticed that in TrackData.java trackTransaction() method when a Transaction instance is created with Transaction.Builder, the setShippingCostInMicros() method is called twice. For the tax setting, it should be:
builder.setTotalTaxInMicros((long) (tax * 1000000));

Easy enough typo, but something to have look at.

Thank you again,

Devon

@alebianco
Copy link
Owner

thanks for pointing that out, I'll fix it as soon as possible

@alebianco alebianco added the bug label Feb 14, 2014
@alebianco alebianco self-assigned this Feb 14, 2014
alebianco added a commit that referenced this issue Feb 14, 2014
use the right method to set the tax costs
alebianco added a commit that referenced this issue Feb 28, 2014
use the right method to set the tax costs
alebianco added a commit that referenced this issue Feb 28, 2014
use the right method to set the tax costs
alebianco added a commit that referenced this issue Jun 16, 2014
use the right method to set the tax costs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants