Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #342

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Update package.json #342

merged 1 commit into from
Oct 28, 2020

Conversation

fade2gray
Copy link
Contributor

Return recently missing BookMarks: Toggle Labeled command to the editor context menu.

Previous...
boomarks-previous
Now...
boomarks-now

Return recently missing BookMarks: Toggle Labeled command to the editor context menu.
@alefragnani
Copy link
Owner

Hi @fade2gray ,

I must be missing something, but I don’t remember, neither found on source history, the Toggle Labeled command available on the Context Menu.

Which version are you referring to? Have you installed the extension from the Extensions view?

Thank you

@fade2gray
Copy link
Contributor Author

Hi @alefragnani ,

Bookmarks 11.4.0 installed from Extensions view which includes package.json "version": "11.4.0".

package.json here is missing the code...

{
     "command": "bookmarks.toggleLabeled",
     "group": "bookmarks",
      "when": "editorTextFocus && config.bookmarks.showCommandsInContextMenu"
 },

I only noticed this recently and can offer no explanation.

@alefragnani
Copy link
Owner

But you said "recently missing", showing a print screen from a supposed previous version with that context menu item. Which version was that?

@fade2gray
Copy link
Contributor Author

I don't know what the previous version was, but it would have been whatever version it was when I posted this.

I patched the current package.json file myself to create the screenshot and get the command back in the context menu.

@alefragnani
Copy link
Owner

Well, I’m not sure how you ended up with that on package.json (maybe you changed the sources yourself), because this command was never there.

Nevertheless, thank you for your PR. The Labeled bookmark is getting a lot of attention on recent releases, so I think this could be a good improvement.

It should be available on the next release.

@alefragnani alefragnani self-assigned this Oct 23, 2020
@alefragnani alefragnani added this to the 11.5.0 milestone Oct 23, 2020
@alefragnani alefragnani self-requested a review October 23, 2020 22:46
@fade2gray
Copy link
Contributor Author

I can only put this down to age and my increasingly failing memory and just forgot that I patched the json file to add the command to the context menu for my own convenience - but it's the kind of thing I would usually have made a feature request for.

I definitely didn't remove it - but I assume that must have happened due to an update around 17/10/2020 ?
boomarks

@alefragnani
Copy link
Owner

No problem, it happens. I already changed some extensions myself, forgot to send a PR to the author, and lost my changes when the extension updated.

Btw, yes, version 11.4 was released October 16th.

@alefragnani alefragnani merged commit 5090260 into alefragnani:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants