Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: add save button #249

Closed
nn-hh opened this issue Jan 19, 2019 · 8 comments
Closed

feature-request: add save button #249

nn-hh opened this issue Jan 19, 2019 · 8 comments

Comments

@nn-hh
Copy link

nn-hh commented Jan 19, 2019

I think it is difficult for vscode beginners to save from the command palette.
I think that it will be useful if you have either a status bar or a sidebar?

@alefragnani
Copy link
Owner

Hi @nn-hh ,

I understand you point, but I would call the Command Palette as the core / heart of VS Code. Everything that you need to do, should be available there. So, I would suggest you to use it. You will se how powerful it is.

In the latest release (10.3.0) I released #227 , which makes the Side Bar visible by default (even if you didn't save a project yet) and also a Save your First Project command, to help you to get started. After that, you should use the Command Palette, using the commands described here. Just a tip, when looking for commands from extensions, start typing the extension's name, prior the command itself. There is an unofficial convention for extension developers to prepend the command name, with the extension's name.

Hope this helps

@nn-hh
Copy link
Author

nn-hh commented Jan 24, 2019

thank you for listening.
I can not speak English.I think it is hard to understand my story. I'm sorry.

I am using it comfortably. projectManager.git.baseFolders very convenient. Thank you.
But housewives who do coding (css, html only) can not understand at all.
Of course, git etc can not be used.
I teach more than three times for one person...

@alefragnani
Copy link
Owner

No need to be sorry. English is not my native language too, and I understand how difficult can be to use a tool in a foreign language. My point is this is how VSCode is designed so if you want to use it, you may adapt your workflow.

You could also to change VSCode language, so instead of English, it would be presented in your native language. There are a lot languages available, and some extensions are already translated. It’s on the roadmap for me #222 (Russian at first).

I’ll keep this issue open for now. Let’s see how many votes it receives, so I could prioritize on future releases.

Hope this helps

@nn-hh
Copy link
Author

nn-hh commented Jan 25, 2019

Thank you for your kindness.

I recommend this project manager to many people.
But where is the save button? It is always asked...

It is only programmers like us who understand quickly.
It seems to be difficult for light users...

Thank you for responding.

@eKoopmans
Copy link

Yeah... I'm a coder and just exploring VS Code, considering making the switch. Project Manager was one of the first extensions I added to try to get the environment feeling comfortable. The Command Palette is not obvious - I'm open to adopting it but I didn't even know what to look for.

I recommend at least adding a line to your readme, e.g. under "Save Project":

You can save the current project in the manager at any time. Just open the Command Palette (Ctrl-Shift-P), enter > Project Manager: Save Project, then type a name.

The feedback within VS Code isn't helpful either - within the Project Manager sidebar, the only clickable thing at the start is the Edit button, and it says "You should open a folder and use Save Project instead". This was very frustrating because there was no indication of how to do this.

I've only now found the "Save your First Project", which was hidden on the "No projects" text - it would be more useful if "Save a project" came up when right-clicking anywhere in the manager window.

@alefragnani
Copy link
Owner

Hi @eKoopmans ,

First of all, thank you for your comments.

I suggest you to replicate this feedback to VS Code team (www.github.com/microsoft/vscode), because as I commented above, the Command Palette is the core and intended to be easy to adopt. If they know how difficult it has been to adopt the concept, they could improve and/or add new solutions.

It's been a while that VS Code team is exploring new UI elements (like the custom Side Bar), but a lot of usability depends on APIs provided by VS Code to extension's developers. For instance, your request to right-clicking anywhere in the manager window, is not possible today, because I can't add a context menu item to the panel (manager window), only to elements (nodes).

About your readme update, I'm open to a PR 😁 . Just don't add the keyboard shortcut, because I don't add those on my readme files anymore.

Hope this helps

@nn-hh
Copy link
Author

nn-hh commented Apr 11, 2019

package.json#219
add

{
    "command": "projectManager.saveProject",
    "when": "view == projectsExplorerFavorites",
    "group": "navigation"
},

I think it's very good.(There is no icon)
@alefragnani Is this useless?

@alefragnani alefragnani added this to the 10.6.0 milestone Jul 27, 2019
@alefragnani
Copy link
Owner

alefragnani commented Jul 27, 2019

Hi @nn-hh ,

No, it's not useless. That's exactly how it works :-). The icon is added in the command itself.

    {
      "command": "projectManager.saveProject",
      "title": "%projectManager.commands.saveProject.title%",
      "icon": {
        "light": "images/ico-save-project-light.svg",
        "dark": "images/ico-save-project-dark.svg"
      }
    },

Sorry for taking so long to revisit the issue. I was focused in other projects. This will be in the next update, this weekend.

Hope this helps

alefragnani added a commit that referenced this issue Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants