-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'Device not ready' error #29
Fix 'Device not ready' error #29
Conversation
Filters out any drive that has an empty fsType on Windows. Additionally, sets the available, free and total size to 0 if diskusage.check raises an error
Thank you for the PR. Have you tested it locally? Is it actually fixing those problems? |
Yes, I've tested it and it fixes the problem and allows the drives to load. I don't have a CD/DVD drive though so it'd be nice if someone could try out the PR. Nevertheless there's probably a more elegant way to handle the problem. For example, do you intend to display RAW drives the same way the Windows Explorer does it? What about CD/DVD drives? Right now I'm simply filtering those out which means they're not displayed at all. |
Perhaps there are some other NPM modules I could use that can not only detect regular drives but also things like CD/DVD. |
Merging it for now since the issue is affecting a lot of people. Thank you very much for the fix! |
The CD/DVD drives are correctly detected, the problem comes from |
@btglr thanks mate. I understand it now. Didn't really sleep for 2 days, so I was a little slow yesterday. I agree that a more elegant way of handling this would have to be added later. |
Filters out any drive that has an empty fsType on Windows.
Additionally, sets the available, free and total size to 0 if diskusage.check raises an error.
Feel free to change whatever needs to be changed if you want to handle it any other way.
Fixes #1
Fixes #2
Fixes #10
Fixes #12
Fixes #13