Fix MiDaS clone by cloning from tag 'v3' #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #164
MiDaS wasn't working after its update to v3.1.
@StMoelter commented with a branch to fix it (thanks!). Since the branch only changed the .ipynb (and not
disco.py) and also introduces some extraneous changes which might result in use ofcolab-createundoing those changes again (and polluting the history a little bit), I re-implemented the changes on disco.py and then rancolab-convertto create the ipynb.I saw that
--depth 1was in there too. It's a nice idea and it would be a better thing to have for use via Colab (i.e. in the .ipynb). For the sake of people potentially doing local development who may benefit from pulling it all, I have mixed feelings about it. I really probably should have put it in.. but I hesitated for a moment and so it's not in there yet.