Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize txs loading in desktop wallet (remove POST) #1088

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Jan 7, 2025

No description provided.

@nop33 nop33 added the 🖥 DW Desktop wallet label Jan 7, 2025
@nop33 nop33 requested a review from mvaivre January 7, 2025 08:19
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 90d1d63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
alephium-desktop-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nop33 nop33 changed the title Optimize latest txs loading in desktop wallet (remove POST) Optimize txs loading in desktop wallet (remove POST) Jan 7, 2025
Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Did some test, only found one thing for now, if I send a TX and I click on the button to "show new transactions", nothing happens.
I have to wait for a while to see the new TX.

image

@nop33
Copy link
Member Author

nop33 commented Jan 8, 2025

Yes, this bug exists in the production as well, I believe it's unrelated to this PR.

@nop33 nop33 requested a review from mvaivre January 8, 2025 02:06
@nop33
Copy link
Member Author

nop33 commented Jan 8, 2025

I fixed the bug

Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super tiny nit, everything seems to be working, approving! 🥇

}
}

const {
useData: useFetchWalletTransactionsLimited,
DataContextProvider: UseFetchWalletTransactionsLimittedContextProvider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in "Limited"

@nop33 nop33 merged commit 36a8ce9 into next Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 DW Desktop wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants