Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Windows binary with FIPS 140-2 compliant setup #261

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Sign Windows binary with FIPS 140-2 compliant setup #261

merged 9 commits into from
Jan 23, 2024

Conversation

killerwhile
Copy link
Member

@killerwhile killerwhile commented Jan 12, 2024 •
edited by nop33
Loading

Closes #265

Closes #264

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 781803d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nop33 nop33 mentioned this pull request Jan 16, 2024
Closed
3 tasks
@nop33 nop33 requested a review from mvaivre January 16, 2024 02:36
@nop33
Copy link
Member

nop33 commented Jan 16, 2024

@mvaivre @killerwhile I added some commits to fix the way we create a release that includes the newly signed windows exe as well as all other needed files. Please review when you have the time, thanks 🙏

@nop33 nop33 force-pushed the sign-windows-binary branch from 5da4591 to ca65da6 Compare January 16, 2024 02:40
@nop33
Copy link
Member

nop33 commented Jan 16, 2024

Converting this to draft because we discovered some issues: #272

@nop33 nop33 marked this pull request as draft January 16, 2024 07:39
@nop33 nop33 removed the request for review from mvaivre January 16, 2024 07:39
@nop33 nop33 requested a review from mvaivre January 22, 2024 07:27
@nop33 nop33 marked this pull request as ready for review January 22, 2024 07:27
@nop33
Copy link
Member

nop33 commented Jan 22, 2024 •
edited
Loading

There are 2 good news and 1 bad news. Good news first:

Signing works! and the auto-update system also works! I tested updating on my Windows VM:

  • from 2.2.1-rc.5 (which was signed with the old workflow and the old certificate)
  • to 2.2.1-rc.6 (which was build and signed with the new workflow and new certificate).

The update worked!

The bad news:

I have this problem: #291

@mvaivre, I believe we can review/merge this PR.

@nop33 nop33 force-pushed the sign-windows-binary branch from 0f1adb5 to c369012 Compare January 22, 2024 10:29
@nop33 nop33 added 🖥 DW Desktop wallet windows labels Jan 23, 2024
nop33
nop33 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nop33 nop33 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewing my code since @mvaivre is on holidays.

@nop33 nop33 merged commit 9dc5caa into master Jan 23, 2024
5 checks passed
@nop33 nop33 deleted the sign-windows-binary branch October 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nop33 nop33 nop33 approved these changes

@mvaivre mvaivre Awaiting requested review from mvaivre

Assignees
No one assigned
Labels
🖥 DW Desktop wallet windows
Projects
None yet
Milestone
No milestone
2 participants
@killerwhile @nop33