Adding a dockerignore file #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-leonhardt mind reviewing? |
|
Hi @RichardoC ! Thanks for the PR! I'm not sure the ssl dirs should be ignored? Dockerfile adds all files of the current dir, including the https://github.com/alex-leonhardt/k8s-mutate-webhook/blob/master/Dockerfile#L8 .. absolutely OK to ignore Let me know if I misunderstand something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces context by ignoring git directories, this will prevent docker builds getting slower and slower over time as the repo grows.
Prevents cert leakage too by ignoring them.
Previously
Sending build context to Docker daemon 8.5MBNow
Sending build context to Docker daemon 7.175MB