Make import rply faster under coverage
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing rply under coverage.py is very slow because of the work done when the rpython libraries are imported. This patch causes the classes needed for translation to be set up only when rply needs to be translated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing rply under coverage.py is very slow because of the work done
when the rpython libraries are imported. This patch causes the classes
needed for translation to be set up only when rply needs to be
translated.
The monkeypatching in the test is pretty ugly but the module needs to get reloaded since we_are_translated() is only checked when the lexergenerator module is first imported.