Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client certificates (mutual TLS) #21

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

defkev
Copy link
Contributor

@defkev defkev commented May 29, 2023

also adds the missing logic for certificate verification (#18) since i had to add a custom TrustManager anyway

Screenshot_20230529_083130

@ippocratis
Copy link

omg
I was long hopping for this
Thanks

@ippocratis ippocratis mentioned this pull request Jan 3, 2024
Also adds the missing logic for certificate verification (alexbakker#18)
since i had to add a custom TrustManager anyway

Co-authored-by: Alexander Bakker <[email protected]>
Copy link
Owner

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made two small adjustments:

  • Added a migration for the introduction if the client_cert column.
  • Got rid of the global static application context

@alexbakker alexbakker merged commit 2ea8a36 into alexbakker:master Mar 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants