Prevent the get trap for the proxy from taking effect if called with internal Symbols or internal 'inspect" prop key #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out when you call "console.log(proxiedThing)" node calls the get trap with built in Symbols In the throw TypeError we subsequently have issues converting the Symbol to a string value implicitly. I opted to just check if the propertty is a symbol or if its the inspect internal string and if it is just short circuit the get trap
alexkolson
changed the title
Closed
alexbepple
reviewed
Oct 28, 2019
alexbepple
reviewed
Oct 28, 2019
|
What is the reason for the changes to Currently, Do you want to work on the PR or shall I just make the changes myself? |
|
@alexbepple done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out when you call
console.log(proxiedThing)node calls the get trap with built in SymbolsIn the
throw TypeErrorstatement we subsequently have issues converting the Symbol to a string value implicitly.I opted to just check if the propertty is a symbol or if its the inspect internal string and if it is just short circuit the get trap.
See also: nodejs/node#10731