debug HFS on other systems #37
Conversation
There was a problem hiding this comment.
Looks like a great addition! I've submitted https://github.com/Eh2406/filetime/pull/1 with just some typo fixups.
|
Thanks! Perhaps this could be a build-time opt-in though rather than a runtime configuration? |
|
What did you have in mind? I guess we could make it a feature flag. That would be un ergonomic if filetime is a transitive dependency, but in that case there is no easy way to tell if the intmeadiet dependency sometimes uses std. |
|
I think either a feature flag or something like requiring |
|
That look better? |
|
Just need to fix s/systom/system/ in the code and README. |
|
I have seriously thought about asking for reddit flare "bad speller", I wish there was something like that for github. Thanks for spotting me! |
|
I can recommend https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen which does both grammatical and spelling mistakes. :) |
|
👍 |
| @@ -37,6 +37,7 @@ | |||
| #[macro_use] | |||
| extern crate cfg_if; | |||
|
|
|||
| use std::env; | |||
There was a problem hiding this comment.
oops. this line can come out.
This is a follow up to the iday from rust-lang/cargo#6484 (comment)
This adds a
FILETIME_EMULATE_SECOND_ONLY_SYSTEM, that allows debugging HFS from other hardware.