Update feed's lastModified if lesser than the item's. fix #323

alexdebril · Jan 29, 2021 · b2eb170 · b2eb170
1 parent fdc54f9
commit b2eb170
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 252 deletions.
diff --git a/src/FeedIo/Feed.php b/src/FeedIo/Feed.php
@@ -169,6 +169,9 @@ public function rewind()
      */
     public function add(ItemInterface $item) : FeedInterface
     {
+        if ($item->getLastModified() > $this->getLastModified()) {
+            $this->setLastModified($item->getLastModified());
+        }
         $this->items->append($item);
 
         return $this;

diff --git a/src/FeedIo/FeedIo.php b/src/FeedIo/FeedIo.php
@@ -232,8 +232,6 @@ public function addFixer(FixerAbstract $fixer) : FeedIo
     public function getBaseFixers() : array
     {
         return array(
-            new Reader\Fixer\LastModified(),
-            new Reader\Fixer\LastModifiedSince(),
             new Reader\Fixer\HttpLastModified(),
             new Reader\Fixer\PublicId(),
         );

diff --git a/src/FeedIo/Reader/Fixer/LastModified.php b/src/FeedIo/Reader/Fixer/LastModified.php
diff --git a/src/FeedIo/Reader/Fixer/LastModifiedSince.php b/src/FeedIo/Reader/Fixer/LastModifiedSince.php
diff --git a/tests/FeedIo/Reader/Fixer/LastModifiedSinceTest.php b/tests/FeedIo/Reader/Fixer/LastModifiedSinceTest.php
diff --git a/tests/FeedIo/Reader/Fixer/LastModifiedTest.php b/tests/FeedIo/Reader/Fixer/LastModifiedTest.php