Skip to content

Commit

Permalink
fix(typings): add more missing typings.
Browse files Browse the repository at this point in the history
This is the same bug pattern I reported in microsoft/TypeScript#5187
  • Loading branch information
alexeagle committed Oct 9, 2015
1 parent 31f48ae commit 98526cb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions modules/angular2/src/core/compiler/selector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export class SelectorMatcher {
* @param matchedCallback This callback will be called with the object handed into `addSelectable`
* @return boolean true if a match was found
*/
match(cssSelector: CssSelector, matchedCallback: (CssSelector, any) => void): boolean {
match(cssSelector: CssSelector, matchedCallback: (c: CssSelector, a: any) => void): boolean {
var result = false;
var element = cssSelector.element;
var classNames = cssSelector.classNames;
Expand Down Expand Up @@ -313,7 +313,7 @@ export class SelectorMatcher {
}

_matchTerminal(map: Map<string, SelectorContext[]>, name, cssSelector: CssSelector,
matchedCallback: (CssSelector, any) => void): boolean {
matchedCallback: (c: CssSelector, a: any) => void): boolean {
if (isBlank(map) || isBlank(name)) {
return false;
}
Expand All @@ -336,7 +336,7 @@ export class SelectorMatcher {
}

_matchPartial(map: Map<string, SelectorMatcher>, name, cssSelector: CssSelector,
matchedCallback /*: (CssSelector, any) => void*/): boolean {
matchedCallback /*: (c: CssSelector, a: any) => void*/): boolean {
if (isBlank(map) || isBlank(name)) {
return false;
}
Expand Down Expand Up @@ -367,7 +367,7 @@ export class SelectorContext {
this.notSelectors = selector.notSelectors;
}

finalize(cssSelector: CssSelector, callback: (CssSelector, any) => void): boolean {
finalize(cssSelector: CssSelector, callback: (c: CssSelector, a: any) => void): boolean {
var result = true;
if (this.notSelectors.length > 0 &&
(isBlank(this.listContext) || !this.listContext.alreadyMatched)) {
Expand Down
8 changes: 4 additions & 4 deletions modules/angular2/src/core/render/dom/events/key_events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import {Injectable} from 'angular2/src/core/di';

var modifierKeys = ['alt', 'control', 'meta', 'shift'];
var modifierKeyGetters: {[key: string]: Function} = {
'alt': (event) => event.altKey,
'control': (event) => event.ctrlKey,
'meta': (event) => event.metaKey,
'shift': (event) => event.shiftKey
'alt': (event: KeyboardEvent) => event.altKey,
'control': (event: KeyboardEvent) => event.ctrlKey,
'meta': (event: KeyboardEvent) => event.metaKey,
'shift': (event: KeyboardEvent) => event.shiftKey
};

@Injectable()
Expand Down
2 changes: 1 addition & 1 deletion modules/angular2/src/core/zone/ng_zone.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class NgZone {
_onTurnStart: () => void;
_onTurnDone: () => void;
_onEventDone: () => void;
_onErrorHandler: (error, stack) => void;
_onErrorHandler: (error: any, stack: any) => void;

// Number of microtasks pending from _innerZone (& descendants)
_pendingMicrotasks: number;
Expand Down

0 comments on commit 98526cb

Please sign in to comment.