Improve handling of version flag #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhromic
changed the title
|
Sorry for all the force pushes, I added extra tests after opening the PR. It is ready for review now :) |
Closed
|
I just discovered a use-case I was not aware before in this comment. |
* Only use/show builtin `--version` flag if args are versioned with a non-empty `Version()` * If args define a `--version` flag, honor it and disable/hide the builtin version flag * Only return `ErrVersion` when using the builtin version flag
|
I think all is good now. Updated the description of this PR with the new behaviour. It should be fully backwards compatible with how the builtin version flag was used before (including manual parsing with |
|
Wonderful, thank you so much for doing this, and for making such a clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when the destination struct is not versioned, the parser still accepts a
--versionflag but prints nothing.This PR fixes the issue by implementing the following improvements to the version flag handling:
--versionflag if args are versioned with a non-emptyVersion()--versionflag, honor it and disable/hide the builtin version flagErrVersionwhen using the builtin version flagThis allows developers to freely define and use their own
--versionflag if they need in the destination struct.Note that if args defines a
--versionflag, it always overrides the builtin version flag, even if args hasVersion().I also split the
TestVersiontest into separate test for each versioning case.Thanks for this great library, really like the API and simplicity!