Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: licencing #1

Open
wants to merge 2 commits into
base: community
Choose a base branch
from

Conversation

niceEli
Copy link

@niceEli niceEli commented Oct 17, 2024

good job! you got full ownership of winamp. so id think lets let everyone have full ownership. :D

@yoshisaac
Copy link

archlinux

Kr3m pushed a commit to Kr3m/winamp that referenced this pull request Oct 17, 2024
Kr3m pushed a commit to Kr3m/winamp that referenced this pull request Oct 17, 2024
Merge pull request alexfreud#1 from WinampDesktop/community
@Valo-King
Copy link

+1 LGTM

licensing*

Copy link

@RubenKelevra RubenKelevra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but it should be GPL v2, as the Winamp source code contains GPL v2 code, this would be the proper license, and the license the Winamp team slapped, on, is nullified by their usage of GPL v2 code.

@niceEli
Copy link
Author

niceEli commented Oct 23, 2024

Thanks, but it should be GPL v2, as the Winamp source code contains GPL v2 code, this would be the proper license, and the license the Winamp team slapped, on, is nullified by their usage of GPL v2 code.

in the gpl license it states that gpl2 and gpl1 code can be in a gpl3 repository

@niceEli niceEli mentioned this pull request Oct 23, 2024
@joeDeuce
Copy link

good job! you got full ownership of winamp. so id think lets let everyone have full ownership. :D

We should definitely incorporate, take the new Winamp Corp public, then pump and dump. Reddit’s r/wallstreetbets will do all the work for us. 🤣

@niceEli
Copy link
Author

niceEli commented Oct 23, 2024

https://github.com/WAmp-Community/WAmp-CE

i was impatient so i just made my own community edition

@niceEli
Copy link
Author

niceEli commented Oct 23, 2024

(also changed Src to src, who actually uses Src)

@RubenKelevra
Copy link

Thanks, but it should be GPL v2, as the Winamp source code contains GPL v2 code, this would be the proper license, and the license the Winamp team slapped, on, is nullified by their usage of GPL v2 code.

in the gpl license it states that gpl2 and gpl1 code can be in a gpl3 repository

That's not necessary true. Most software used "GPLv2 or later" before GPLv3 came out, some software didn't. Linux for example was a prominent example.

@RubenKelevra
Copy link

RubenKelevra commented Oct 23, 2024

https://github.com/WAmp-Community/WAmp-CE

i was impatient so i just made my own community edition

You don't need to squash the tree, you can use git filter repo, to rewrite the history without certain folders. :)

But again: If software is build with GPL code and shipped as binary, all shipped source code becomes legally "free" under the GPL.

@niceEli
Copy link
Author

niceEli commented Oct 23, 2024

https://github.com/WAmp-Community/WAmp-CE
i was impatient so i just made my own community edition

You don't need to squash the tree, you can use git filter repo, to rewrite the history without certain folders. :)

But again: If software is build with GPL code and shipped as binary, all shipped source code becomes legally "free" under the GPL.

I felt doing a squash was best to fully avoid legal trouble because of proprietary code, after all people are imperfect, but just combining everything is perfect. Also wasn't a squash really, I deleted .git and did from scratch.

@RubenKelevra
Copy link

@niceEli filtering a git does exactly what you want: It can remove parts of the git repo from ever having existed, while preserving the full history of the repository.

@niceEli
Copy link
Author

niceEli commented Oct 25, 2024

@niceEli filtering a git does exactly what you want: It can remove parts of the git repo from ever having existed, while preserving the full history of the repository.

Again, i deleted the .git to start from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants