Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash Autocompletion Issue: Incorrect Handling of Spaces and Special Characters #180

Closed
a90091343 opened this issue Jan 16, 2024 · 2 comments · Fixed by #188
Closed

Bash Autocompletion Issue: Incorrect Handling of Spaces and Special Characters #180

a90091343 opened this issue Jan 16, 2024 · 2 comments · Fixed by #188

Comments

@a90091343
Copy link

a90091343 commented Jan 16, 2024

Version Information: Ubuntu 22.04.3 LTS; ab-av1 Version: v0.7.12; cargo Version: 1.75.0 (1d8b05cdd 2023-11-20)
Installation Method: Installed using 'cargo install ab-av1'
Issue:
I encountered a problem with the bash autocompletion feature in the ab-av1 software. I followed the recommended steps to enable autocompletion using the provided command:
printf '. <(ab-av1 print-completions bash)\n' > ~/.local/share/bash-completion/completions/ab-av1

Steps to Reproduce:

  1. Have files with spaces and special characters, for example:
    'Dont.Look.Up.-(copy).mkv' 'Great details 8K AV1 HDR 60FPS (FUHD).mp4'
  2. Run the command $ ab-av1 encode -i.
  3. Double-tab for autocompletion.

Expected Behavior:
The bash autocompletion should correctly handle spaces and special characters, displaying suggestions similar to:
$ ls Great\ details\ 8K\ AV1\ HDR\ 60FPS\ \(FUHD\).mp4
or
$ ls Dont.Look.Up.-\(copy\).mkv

Current Behavior:
The autocompletion suggestions are displayed incorrectly, failing to handle spaces and special characters properly. Autocompletion suggestions appear as:

$ ab-av1 encode -i 
Dont.Look.Up.-(copy).mkv  details                   AV1                       60FPS                     
Great                     8K                        HDR                       (FUHD).mp4

Additional Information:
The issue makes it challenging to work with files containing spaces and special characters using ab-av1. Please consider addressing this autocompletion problem for a more user-friendly experience. Thank you!

@alexheretic
Copy link
Owner

Bash completions are generated using clap_complete crate: I've raised an issue upstream.

@a90091343
Copy link
Author

Thank you for your prompt response and for looking into the issue!

sudotac added a commit to sudotac/ab-av1 that referenced this issue Feb 3, 2024
alexheretic pushed a commit that referenced this issue Feb 3, 2024
* Bump clap_complete to 4.4.10

* Specify value_hint macro for better completion

Fix #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants