Draw-cache: Optimise empty cache-queued into single texture upload #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optimisation targeting whenever the cache is empty & multiple new glyphs have been drawn in a call to
cache_queued
, e.g. the initial population of the cache & when it must be re-orded to fit all glyphs after a change.In this case total in-use region of the texture will be saved in memory during the
cache_queued(self, fonts, uploader)
call and provided with a single callback touploader
. This minimises uploads to the gpu in common cases which should be faster.cache_queued
calls to a non-empty cache are not effected.Benchmarks
The draw-cache v2 benchmarks simulate gpu uploads by busy waiting for 4us, this allows us to benchmark this improvement in a artificial way.
Non-populating benchmarks were not effected, as expected. Populating & reordering benchmarks were:
multi_font_population_v2
-63.5%resizing_v2
-59.1%moving_text_thrashing_v2
-58.3%Related to discussion in #120