Windows use hint::spin_loop() + expose fn native_sleep + add "experiments" testing bins
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexheretic
force-pushed
the
experiments
branch
from
0d9419e to
0af0c0a
Compare
Add experiments bins
alexheretic
force-pushed
the
experiments
branch
from
f8ea8a9 to
fd09ba0
Compare
alexheretic
force-pushed
the
experiments
branch
from
fd09ba0 to
acd1dec
Compare
alexheretic
changed the title
native_sleep & add "experiments" testing binarieshint::spin_loop() + expose fn native_sleep + add "experiments" testing bins
ishitatsuyuki
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native_sleep.SpinSleeper::with_spin_strategywhich allows specifying aSpinStrategy.SpinStrategy::SpinLoopHintby default.Add experiments directory with binaries to help pick OS defaults. In particular measuring spin latencies; I saw Linux has good performance using the current
thread::yield_now()behaviour. However, on Windows performance under load is quite poor. This supports #11 in suggestingstd::hint::spin_loop()is a better default on Windows.The downside of the change is that in non-load scenarios on Windows we'll now spin more using more power.
Linux
Windows