Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in TypeScript #97

Merged
merged 5 commits into from
Apr 5, 2018
Merged

Rewrite in TypeScript #97

merged 5 commits into from
Apr 5, 2018

Conversation

alexlafroscia
Copy link
Owner

No description provided.

@alexlafroscia
Copy link
Owner Author

alexlafroscia commented Apr 4, 2018

The 2.12 errors came from the fact that TypeScript requires using Ember classes as regular ES6 ones. I think it's time to drop official 2.12 support, especially since v4.0.0 of this addon will work with it and has the "updated" API.

Related Ember issue to the failures in beta/canary: emberjs/ember.js#16464

Necessary for Ember 3.1 support and does not break older Ember versions.
Unfortunately, the type definitions specify that there should be no
arguments to the constructor, so I have to see about that, too...
- Remove dependency on `htmlbars-inline-precompile`
- Ignore places where the TypeScript definition for Ember is wrong
@alexlafroscia alexlafroscia force-pushed the rewrite-in-typescript branch from 8f29fa9 to 7d14f81 Compare April 4, 2018 22:44
@alexlafroscia alexlafroscia merged commit 7d14f81 into master Apr 5, 2018
@alexlafroscia alexlafroscia deleted the rewrite-in-typescript branch April 18, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant