changes due to making project & library public #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
meck93
commented
Apr 8, 2020
meck93
commented
- sealer & voting-authority backend -> need bignumber.js as dev dependency due to web3js bug: Typescript compilation error regarding a bignumber.js import web3/web3.js#3386
- published @meck93/evote-crypto on npm
- remove all .npmrc files (no longer needed)
- remove github.json and reading github config from most build scripts since it's no longer needed
- sealer & voting-authority backend -> need bignumber.js as dev dependency due to web3js bug: web3/web3.js#3386 - remove all .npmrc files (no longer needed, @meck93/evote-crypto is a public npm package) - remove github.json and reading github config from most build scripts since it's no longer needed
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
meck93
commented
Apr 8, 2020
Comment on lines
+6
to
+29
| "@material-ui/core": "^4.9.9", | ||
| "@material-ui/icons": "^4.9.1", | ||
| "axios": "^0.19.2", | ||
| "lint-staged": "^9.5.0", | ||
| "prettier": "^1.19.1", | ||
| "react": "^16.12.0", | ||
| "react-dom": "^16.12.0", | ||
| "react": "^16.13.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-router-dom": "^5.1.2", | ||
| "react-scripts": "^3.3.0", | ||
| "react-scripts": "^3.4.1", | ||
| "styled-components": "^4.4.1", | ||
| "zustand": "^2.2.1" | ||
| "zustand": "^2.2.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "24.0.23", | ||
| "@types/node": "12.12.12", | ||
| "@types/react": "16.9.14", | ||
| "@types/react-dom": "16.9.4", | ||
| "@types/react-router-dom": "^5.1.2", | ||
| "@types/styled-components": "^4.4.0", | ||
| "@typescript-eslint/eslint-plugin": "^2.8.0", | ||
| "@typescript-eslint/parser": "^2.8.0", | ||
| "eslint-config-prettier": "^6.7.0", | ||
| "@types/react-router-dom": "^5.1.3", | ||
| "@types/styled-components": "^4.4.3", | ||
| "@typescript-eslint/eslint-plugin": "^2.27.0", | ||
| "@typescript-eslint/parser": "^2.27.0", | ||
| "eslint-config-prettier": "^6.10.1", | ||
| "eslint-config-react": "^1.1.7", | ||
| "eslint-plugin-prettier": "^3.1.1", | ||
| "eslint-plugin-prettier": "^3.1.2", |
There was a problem hiding this comment.
this was more of an accident but I don't think it should affect a lot...
|
I have tested the following:
|
alexscheitlin
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Nice, this works as expected. Thanks!
I did the following (checks):
- install docker on a new machine
- clone the repo and this branch and create
github.jsonaccording to the readme - run
./docker-prebuilt-up.sh - play through the whole voting process
- run
npm installin both the FE and BE of the voting-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.