Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional items #111

Closed
cbellone opened this issue Mar 24, 2016 · 6 comments
Closed

Support additional items #111

cbellone opened this issue Mar 24, 2016 · 6 comments
Assignees
Milestone

Comments

@cbellone
Copy link
Member

cbellone commented Mar 24, 2016

Event organizers should be able to sell "additional items", such as event T-Shirts, upgrade packages etc.

@cbellone cbellone added this to the BackLog milestone Mar 24, 2016
@cbellone cbellone modified the milestones: 1.9, BackLog Apr 7, 2016
cbellone added a commit that referenced this issue Jun 22, 2016
cbellone added a commit that referenced this issue Jun 22, 2016
@cbellone cbellone removed this from the 1.9 milestone Oct 22, 2016
@cbellone cbellone added this to the 1.10 milestone Nov 4, 2016
@cbellone cbellone modified the milestones: 2.0, 1.10 Jan 25, 2017
@cbellone cbellone modified the milestones: 1.11, 2.0 Apr 11, 2017
@syjer syjer changed the title Support additional services Support additional items May 15, 2017
@syjer
Copy link
Member

syjer commented May 15, 2017

  • rename current additional items in donations (?) -> could potentially reuse/extend part of the current additional services logic/tables
  • necessary feature: "supplement" mandatory additional item (1 for each ticket in a reservation) (for legal reasons)

syjer added a commit that referenced this issue May 17, 2017
syjer added a commit that referenced this issue May 19, 2017
@syjer
Copy link
Member

syjer commented May 19, 2017

TODO:

  • select only valid MANDATORY_ONE_FOR_TICKET (currently select all)
  • validation logic for the others policy: kept simple, could be improved
  • ui admin
    • creation of new additional options
    • update the ui to suppport the new types of additional options
  • ui user
    • rename enabledAdditionalServices in enabledAdditionalServicesDonations -> update ui
    • expose the supplement section
    • update the ui to support the new types of additional options
      • handle MANDATORY_ONE_FOR_TICKET -> show only text + price
      • handle OPTIONAL_UNLIMITED_AMOUNT -> put an input field for selecting the quantity instead of a select box
      • handle OPTIONAL_MAX_AMOUNT_PER_TICKET -> dynamically update the max/min quantity in the select box

Sorry, something went wrong.

syjer added a commit that referenced this issue May 21, 2017
syjer added a commit that referenced this issue May 22, 2017
…_ticket additional services, update ui to handle this additional service too
syjer added a commit that referenced this issue May 22, 2017
@syjer
Copy link
Member

syjer commented May 22, 2017

done!

@syjer syjer closed this as completed May 22, 2017
@cbellone
Copy link
Member Author

I have defined an additional option mandatory, one per ticket:

image

then I found the following errors:

  • missing data on edit
    image

  • the supplement has been applied twice (instead of just once) on the reservation

image

@syjer
Copy link
Member

syjer commented May 25, 2017

second issue fixed.

@syjer
Copy link
Member

syjer commented May 25, 2017

first issue fixed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants