Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused/useless profiles #544

Closed
3 tasks done
syjer opened this issue Nov 12, 2018 · 1 comment
Closed
3 tasks done

remove unused/useless profiles #544

syjer opened this issue Nov 12, 2018 · 1 comment
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M1

Comments

@syjer
Copy link
Member

syjer commented Nov 12, 2018 •
edited
Loading

As defined in https://github.com/alfio-event/alf.io/blob/master/src/main/java/alfio/config/Initializer.java#L40

We have the following profiles that can potentially be removed:

  • PROFILE_JDBC_SESSION -> enable by default
  • PROFILE_USE_WORKER_NAME -> could be removed
  • PROFILE_DEBUG_CSP -> check (let the user define the report-uri. If it's defined (like https://report-uri.com/), then the logger in the csp debug controller will by bypassed. This will allow to remove the profile)

This should reduce the variance of configurations :)
@syjer syjer added this to the 2.0-M1 milestone Nov 12, 2018
syjer added a commit that referenced this issue Nov 13, 2018
@syjer
#544 remove jdbc-session (always enabled) and use-worker-name (always…
49926df 
… disabled) spring profiles.
syjer added a commit that referenced this issue Nov 13, 2018
@syjer
#544 csp logging: read body only if necessary
8f8b9d8
@syjer syjer self-assigned this Nov 13, 2018
cbellone pushed a commit that referenced this issue Nov 14, 2018
@syjer @cbellone
implement #544 refactor profiles (#548)
9877f72 
* #544 remove jdbc-session (always enabled) and use-worker-name (always disabled) spring profiles.

* remove debug-csp profile, add configuration for setting report-uri instead

* #544 csp logging: read body only if necessary
@syjer
Copy link
Member Author

syjer commented Nov 14, 2018

has been merged.

@syjer syjer closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M1
Development

No branches or pull requests
1 participant
@syjer