Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if we can use spring aop directly instead of aspectj #669

Closed
syjer opened this issue Jun 20, 2019 · 1 comment
Closed

check if we can use spring aop directly instead of aspectj #669

syjer opened this issue Jun 20, 2019 · 1 comment
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M3

Comments

@syjer
Copy link
Member

syjer commented Jun 20, 2019 •
edited
Loading

Currently, we are using the @Around advice aspect in https://github.com/alfio-event/alf.io/blob/master/src/main/java/alfio/config/RowLevelSecurity.java . But in fact, as the code is structured, we only need a "execute before" behaviour which, as far as I know, is supported by spring aop.

So, check if it's possible :)

Goal: drop the org.aspectj:aspectjweaver:1.9.4 deps.
@syjer syjer added this to the 2.0-M2 milestone Jun 20, 2019
@syjer syjer self-assigned this Jun 20, 2019
@syjer syjer modified the milestones: 2.0-M2, 2.0-M3 Jul 8, 2019
syjer added a commit to syjer/alf.io that referenced this issue Aug 4, 2020
@syjer
alfio-event#669 remove aspectj, now we execute the row level security…
cc86873 
… related queries in a custom DataSourceTransactionManager.prepareTransactionalConnection
cbellone pushed a commit that referenced this issue Aug 5, 2020
@syjer
#669 remove aspectj, now we execute the row level security related qu…
9429bea 
…eries in a custom DataSourceTransactionManager.prepareTransactionalConnection (#937)

* #669 remove aspectj, now we execute the row level security related queries in a custom DataSourceTransactionManager.prepareTransactionalConnection

* bail out faster
@syjer
Copy link
Member Author

syjer commented Aug 5, 2020 •
edited
Loading

done :).

We have bypassed the AOP part totally.

@syjer syjer closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M3
Development

No branches or pull requests
1 participant
@syjer