Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing days in the tickets sold chart #874

Closed
salmar opened this issue Feb 24, 2020 · 1 comment
Closed

Missing days in the tickets sold chart #874

salmar opened this issue Feb 24, 2020 · 1 comment
Labels
enhancement

Comments

@salmar
Copy link
Contributor

salmar commented Feb 24, 2020

Describe the bug
In the tickets sold / reserved chart from the dashboard, if the hasn't been any tickets sold or reserved on a specific day, that day is skipped. This gives the false impression that there are always reservations just by looking at the chart.

To Reproduce
Steps to reproduce the behavior:
1.- Make reservations on day 1
2.- Make reservations on day 4
3.- Check the chart and you will see no day has 0 reservations, day 2 and 3 are just skipped

Expected behavior
All days should appear in the chart. The /api/events/{eventId}/ticket-sold-statistics endpoint should include all days (until the event day) both in the sold and reserved arrays when reservations are 0.

Screenshots
Screenshot 2020-02-24 at 17 08 52
cbellone added a commit that referenced this issue Mar 22, 2020
@cbellone
#874 - add missing data points, show weeks instead of days in case th…
e16b8d3 
…e graphs shows more than 3 months
cbellone added a commit that referenced this issue Mar 22, 2020
@cbellone
#874 - fix integration test
f5c8537
cbellone added a commit that referenced this issue Mar 23, 2020
@cbellone
#874 - add month granularity
56bfbe9
cbellone added a commit that referenced this issue Mar 23, 2020
@cbellone
#874 - fix integration test
61d28fb
cbellone added a commit that referenced this issue Mar 24, 2020
@cbellone
#874 - add missing data points, show weeks instead of days in case th…
4e42708 
…e graphs shows more than 3 months

(cherry picked from commit e16b8d3)
cbellone added a commit that referenced this issue Mar 24, 2020
@cbellone
#874 - add month granularity
291c7bb 
(cherry picked from commit 56bfbe9)
cbellone added a commit that referenced this issue Mar 24, 2020
@cbellone
#874 - fix integration test
6e0adb1
cbellone added a commit that referenced this issue Mar 24, 2020
@cbellone
#874 - fix integration test
7837989
@cbellone
Copy link
Member

implemented and backported to M2. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@salmar @cbellone