fix(error): directly emit error from events #6472
Merged
+28
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7db5481:
|
aymeric-giraudet
approved these changes
Dec 12, 2024
Haroenv
added a commit
that referenced
this pull request
Dec 17, 2024
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Dec 26, 2024
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 27, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Haroenv
added a commit
that referenced
this pull request
Jan 28, 2025
In `@algolia/events`, errors are properly rethrown if they are thrown with `.emit('error', new Error("msg"))`, not if they are thrown with `.emit('error', { error: new Error('msg') })`. Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.
[FX-3187]
BREAKING CHANGE: if you have any `on('error'` handler that reads `event.error` from the callback, change that to just `error`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
@algolia/events, errors are properly rethrown if they are thrown with.emit('error', new Error("msg")), not if they are thrown with.emit('error', { error: new Error('msg') }). Therefore in InstantSearch and the helper, all errors are now properly thrown directly in the emit.FX-3187
BREAKING CHANGE: if you have any
on('error'handler that readsevent.errorfrom the callback, change that to justerror