fix(insights): detect appId and apiKey from client directly in v5 #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the plain parameters is easier to implement in custom clients. I'll also see if i can do a pull request to the client to add applicationId/apiKey to the object to make this the simple case.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c27922:
|
dhayab
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the insights middleware / getAppIdAndApiKey function we quickly fall back to the brittle logic with transporter. I've made a PR to the client (algolia/api-clients-automation#4285) to expose appId and apiKey directly on the object, so newer v5 will mostly use this logic.
Result
in v5 we use
appIdandapiKeyfrom the client, which can also be a good way to be documented for custom clients