Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relevance): add another query rule on name #191

Closed
wants to merge 1 commit into from
Closed

feat(relevance): add another query rule on name #191

wants to merge 1 commit into from

Conversation

Haroenv
Copy link
Collaborator

@Haroenv Haroenv commented Apr 30, 2018

We earlier added a query rule on concatenated name to promote if that matched, but for a query like react-native, you still want that first.

@Haroenv Haroenv mentioned this pull request Apr 30, 2018
Merged
@Haroenv
Copy link
Collaborator Author

Haroenv commented Apr 30, 2018

__DO_NOT_USE_OR_YOULL_BE_FIRED_npm-search is the index both this and #192 can be tested on

@Haroenv
Copy link
Collaborator Author

Haroenv commented Apr 30, 2018

This helps for the query react-native (note that it's not react native, maybe we need a third query rule that does split name where we replace special characters with spaces)

@Haroenv
feat(relevance): add another query rule on name
f14b12b 
We earlier added a query rule on concatenated name to promote if that matched, but for a query like `react-native`, you still want that first.
@Haroenv Haroenv force-pushed the feat/more-query-ruling branch from 34c6df4 to f14b12b Compare April 30, 2018 15:13
@Haroenv Haroenv mentioned this pull request Apr 30, 2018
Closed
@Haroenv Haroenv closed this May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Haroenv